James Spinella
1 min readMar 29, 2022

--

Most developers I have worked with don't seem to be interested in spending more than ~2 minutes reviewing a PR and it shows. Often obvious issues would go unidentified, and at one company actual bugs would go to production because the developers didn't want to wait for my PR review - and I can't really blame them- I had a tendency to go to town on that team's PRs. I had to ask myself whether I wanted to allow "nits" (they weren't really nits but they weren't urgent, high-level issues either) to catch the bugs or try (unsuccessfully) to catch all issues before a PR was approved by someone else and merged. Fun stuff.

On the other hand, I have been berated in the past for spending an hour or more on a single (it was large) PR, and my review consisted of pulling the feature branch and running the code locally. Sometimes that's the right approach though.

It's remarkable how inconsistent the SDLC is from one company to another.

--

--

James Spinella
James Spinella

Written by James Spinella

Growing up, I loved building computers, and now I write code for a living. I am also interested in the “human element” of software development.

No responses yet